Conversation
jjgray
reviewed
Mar 10, 2021
Member
jjgray
left a comment
jjgray
left a comment
There was a problem hiding this comment.
Looks good to me with one caveat!
A few files look like they may be back-peddling to old versions. Please check, then I can approve.
| "protocol = parser.generate_mover(\"inputs/min_L1.xml\")\n", | ||
| "\n", | ||
| "if not os.getenv(\"DEBUG\"):\n", | ||
| " parser = RosettaScriptsParser()\n", |
Member
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.7.6" | ||
| "version": "3.6.1" |
Member
There was a problem hiding this comment.
in fact this looks like a clue that the PR clobbers a newer version of this file with an older version. please check.
| "minmover.set_movemap(mm)\n", | ||
| "\n", | ||
| "for i in range(1, 5):\n", | ||
| " minmover.apply(p)\n", |
Member
There was a problem hiding this comment.
same comment...clobbering new file with old?
Member
|
As Jeff said, I think maybe you need to pull in master before these changes? Chapter 10 - working with density looks mangled somehow. I think this was branched off of an older version... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.