Decreasing the number of dynamically shadowed bindings#233
Open
JackMaguire wants to merge 19 commits intoRosettaCommons:mainfrom
Open
Decreasing the number of dynamically shadowed bindings#233JackMaguire wants to merge 19 commits intoRosettaCommons:mainfrom
JackMaguire wants to merge 19 commits intoRosettaCommons:mainfrom
Conversation
remove bool/int pairs. Should be way less than 266 now
Member
Author
|
@lyskov Why did Edit: This isn't urgent. I found a workaround. I'm more just curious about why it failed than how to fix it |
Member
Author
|
Down from 276 to 182 |
Member
-- one need to use full C++ class/function name with all template arguments. Easiest way to find such name is to look at generated C++ sources (see protocols::mean_field::jagged_array<protocols::mean_field::AAProb,std::allocator<protocols::mean_field::AAProb>> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nowhere near ready for review...