Proposed RosettaScripts syntax alterations to make using MultiplePoseMover easier#494
Open
roccomoretti wants to merge 8 commits intoRosettaCommons:mainfrom
Open
Proposed RosettaScripts syntax alterations to make using MultiplePoseMover easier#494roccomoretti wants to merge 8 commits intoRosettaCommons:mainfrom
roccomoretti wants to merge 8 commits intoRosettaCommons:mainfrom
Conversation
Member
|
Thanks @roccomoretti, this is amazing! I am out of office until aug 18, but will test/review as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ajasja had requested some changes/additions to the MultiplePoseMover system to make using it more convenient. In particular, to reduce the requirement for specifying a full RosettaScript, and to allow MuliplePoseMover functionality (and thus control flow) to be more easily specified in the PROTOCOLS section.
This PR:
FOR_EACH_POSEtag (vs. anAddtag) in the PROTOCOLS section or the ParsedProtocol Mover, which is taken to be a MultiplePoseMover.This should allow you to do something like the following as your main protocols block (no complete ROSETTA_SCRIPTS needed):
This is just a draft, and we may want to adjust the syntax and/or semantics of how things work. (Most notably, there's differences in object-sharing between different runs which comes along with re-using top-level movers/etc., rather than re-specifying a full RosettaScript which gets re-parsed for each pose.) We probably also want to see how it fares in practical use (e.g. @ajasja's driving use cases).
No current functionality should be erased by the syntax changes.