Skip to content
This repository was archived by the owner on Nov 9, 2019. It is now read-only.

[WIP] add initial vagrant configuration#1956

Closed
maglnet wants to merge 22 commits intoRunalyze:masterfrom
maglnet:feature/vagrant
Closed

[WIP] add initial vagrant configuration#1956
maglnet wants to merge 22 commits intoRunalyze:masterfrom
maglnet:feature/vagrant

Conversation

@maglnet
Copy link
Contributor

@maglnet maglnet commented Oct 3, 2016

This should make it easier for developers to setup a working Runalyze installation.

If you have vagrant installed, vagrant up should setup a virtual machine, which has runalyze installed and is available at http://localhost:8080

Todo:

  • perform composer install if no vendor/ directory exists
  • perform runalyze installation
  • perform npm install
  • perform gulp install
  • copy config.yml if it doesn't exist
  • make database accessible from the host
  • add documentation to README
  • add documentation to Runalyze/admin-docs - add vagrant instructions admin-docs#23
  • add installation for timezone detection

feel free to give your feedback :)

Copy link
Contributor

@laufhannes laufhannes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't know anything about Vagrant, so I can't provide profound feedback and I won't be able to provide support for this part of the repo later on, but I guess that's not a problem at all.

Concerning the file locations: Are the files in data/vagrant/ meant to be edited by users? The data/ directory is meant for all installation-specific files that won't be touched by updates, so that directory should be empty. I guess app/vagrant/ fits better, but I don't know if there's any best practice.

@mipapo does probably know more about this topic than I do.

@maglnet
Copy link
Contributor Author

maglnet commented Oct 3, 2016

Just a short explanation about vagrant:
Vagrant is (not only) meant to help developers setting up a development environment. It should help with those "but it works on my machine" issues, since the environment is the same for all developers.

The files within data/vagrant are only needed once to install the virtual machine and configure apache and MySQL, so they do not really belong to the application so
imho the app directory is not the right place for those files. I don't know if there's a best practice for file location, I'll check some other repositories.

Am 3. Oktober 2016 21:43:51 MESZ, schrieb Hannes notifications@github.com:

laufhannes commented on this pull request.

I personally don't know anything about Vagrant, so I can't provide
profound feedback and I won't be able to provide support for this part
of the repo later on, but I guess that's not a problem at all.

Concerning the file locations: Are the files in data/vagrant/ meant
to be edited by users? The data/ directory is meant for all
installation-specific files that won't be touched by updates, so that
directory should be empty. I guess app/vagrant/ fits better, but I
don't know if there's any best practice.

@mipapo does probably know more about this topic than I do.

You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#1956 (review)

@maglnet
Copy link
Contributor Author

maglnet commented Apr 9, 2017

btw: I have no idea how to fix the travis build error, seems this has something to do with automatic deployment:

The command "openssl aes-256-cbc -K $encrypted_d056b0ac7927_key -iv $encrypted_d056b0ac7927_iv -in bin/deploy_rsa.enc -out /tmp/deploy_rsa -d" failed and exited with 1 during .

@laufhannes
Copy link
Contributor

I think we can ignore travis for this pr, as there are no changes in any php file. Travis fails because of https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions. I guess we need to wrap the first four lines of before_install in some 'if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then ...; fi'.

@mipapo mipapo closed this Nov 8, 2019
@maglnet maglnet deleted the feature/vagrant branch November 11, 2019 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants