This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Add doc_comment to test README.md#162
Open
nicochatzi wants to merge 3 commits intoRustAudio:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another one from a suggestion by @Boscop. This adds README's Rust code block as a doctest in lib.rs. doc_comment seems less intrusive than skeptic since it doesn't require a separate build step that generates a temporary file and paste it into a test file. It does have the caveat that if the test fails it looks as if the lib.rs failed. To make it more obvious that a test failure in lib is related to the README, this PR moves
plugin_maincode into a separate file. Any thoughts?