Consolidate ct modules
#1104
Merged
Consolidate ct modules
#1104
+733
−725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates modules containing all constant-time functionality for each numeric type, including: `Int`, `Uint`, `BoxedUint`, `ConstMontyForm`, `MontyForm`, and `BoxedMontyForm`. It's the new home for any `ctutils::Ct*` impls or `subtle` trait impls. This makes auditing the constant-time operations easier, and is also in anticipation of having to add additional `CtAssign` impls to all types when we bump `ctutils`.
Member
Author
|
I think we may have even had it factored this way at one point in the past 😅 Without this structure it's a bit unclear where to put the |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1104 +/- ##
==========================================
- Coverage 79.26% 79.24% -0.02%
==========================================
Files 177 175 -2
Lines 18088 18091 +3
==========================================
Hits 14337 14337
- Misses 3751 3754 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates modules containing all constant-time functionality for each numeric type, including:
Int,Uint,BoxedUint,ConstMontyForm,MontyForm, andBoxedMontyForm.It's the new home for any
ctutils::Ct*impls orsubtletrait impls.This makes auditing the constant-time operations easier, and is also in anticipation of having to add additional
CtAssignimpls to all types when we bumpctutils.