Add ctutils trait impls: CtAssignSlice/CtEqSlice
#1106
Merged
+160
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1106 +/- ##
==========================================
- Coverage 79.66% 79.65% -0.01%
==========================================
Files 176 176
Lines 18211 18212 +1
==========================================
- Hits 14507 14506 -1
- Misses 3704 3706 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Also fills in some missing `CtAssign` impls and leverages the new `CtSelectUsingCtAssign` marker trait. The `*Slice` impls make it possible to use `CtAssign` and `CtEq` on `[T]` for the types which impl it in this crate. `Limb` uses an optimized implementation which does what the impls on `Uint`/`UintRef` were previously doing: leveraging `as_(mut_)words` and then using the impls on that. Now everything should just work!
tarcieri
force-pushed
the
add-ctutils-trait-impls
branch
from
0140031 to
21afe27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fills in some missing
CtAssignimpls and leverages the newCtSelectUsingCtAssignmarker trait.The
*Sliceimpls make it possible to useCtAssignandCtEqon[T]for the types which impl it in this crate.Limbuses an optimized implementation which does what the impls onUint/UintRefwere previously doing: leveragingas_(mut_)wordsand then using the impls on that.Now everything should just work!