Unified GenericMontyParams
#1107
Open
+147
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces `struct MontyParams` and `struct BoxedMontyParamsInner` with type aliases for a single struct which is generic around `U: Unsigned`, as these two types previously had identical structure and only differed in the unsigned integer type they used. This makes it possible to consolidate some impls generically.
tarcieri
force-pushed
the
crypto-bigint/unified-monty-params
branch
from
9b972af to
105196e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 79.65% 79.60% -0.05%
==========================================
Files 176 177 +1
Lines 18212 18222 +10
==========================================
Hits 14506 14506
- Misses 3706 3716 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
struct MontyParamsandstruct BoxedMontyParamsInnerwith type aliases for a single struct which is generic aroundU: Unsigned, as these two types previously had identical structure and only differed in the unsigned integer type they used.This makes it possible to consolidate some impls generically.