Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 48 additions & 33 deletions pr-review/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@vercel/ncc": "0.38.4",
"eslint": "9.39.3",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.7",
"eslint-plugin-sonarjs": "4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've updated eslint-plugin-sonarjs from 3.0.7 to 4.0.0, a major release with possible breaking changes. Please:

  • Review the plugin's changelog or migration guide for any breaking changes.
  • Adjust your ESLint configuration if new rules are introduced or defaults have changed.
  • Consider using a caret range (^4.0.0) instead of pinning to an exact version to allow for non-breaking patch updates.

Example:

{
  ...
  "eslint-plugin-sonarjs": "^4.0.0",
  ...
}

After updating the specifier, run npm install (or yarn install) to regenerate your lockfile and ensure dependency consistency across environments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re bumping eslint-plugin-sonarjs from 3.x to 4.x, which is a major upgrade and may introduce breaking changes in rule names, behavior, or defaults. Make sure to:

  • Review the changelog for any renamed or removed rules and update your ESLint config accordingly.
  • Run a full lint pass to catch new warnings or errors.
  • Update your lockfile (e.g., package-lock.json or pnpm-lock.yaml).

Also, consider using a caret range to allow future non-breaking updates automatically:

"eslint-plugin-sonarjs": "^4.0.0"

"eslint-plugin-unicorn": "63.0.0",
"prettier": "3.8.1",
"tsx": "4.21.0",
Expand Down
81 changes: 48 additions & 33 deletions pr-summary/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-summary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@vercel/ncc": "0.38.4",
"eslint": "9.39.3",
"eslint-plugin-import": "2.32.0",
"eslint-plugin-sonarjs": "3.0.7",
"eslint-plugin-sonarjs": "4.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've updated eslint-plugin-sonarjs from 3.0.7 to 4.0.0, a major release with possible breaking changes. Please:

  • Review the plugin's changelog or migration guide for any breaking changes.
  • Adjust your ESLint configuration if new rules are introduced or defaults have changed.
  • Consider using a caret range (^4.0.0) instead of pinning to an exact version to allow for non-breaking patch updates.

Example:

{
  ...
  "eslint-plugin-sonarjs": "^4.0.0",
  ...
}

After updating the specifier, run npm install (or yarn install) to regenerate your lockfile and ensure dependency consistency across environments.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module has the same devDependencies as pr-review. To avoid duplication and reduce maintenance overhead, consider centralizing shared ESLint tooling in a workspace root or a shared configuration package. For example, in your root package.json:

{
  "devDependencies": {
    "eslint-plugin-sonarjs": "^4.0.0",
    "eslint": "^9.39.3",
    "eslint-plugin-unicorn": "^63.0.0",
    // …
  }
}

Then each sub-package can extend the shared ESLint config, keeping versions in sync across the repo.

"eslint-plugin-unicorn": "63.0.0",
"prettier": "3.8.1",
"tsx": "4.21.0",
Expand Down