-
Notifications
You must be signed in to change notification settings - Fork 4
Update dependency @types/node to v24.11.0 #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,7 +31,7 @@ | |
| }, | ||
| "devDependencies": { | ||
| "@eslint/js": "9.39.3", | ||
| "@types/node": "24.10.15", | ||
| "@types/node": "24.11.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider using caret ( "@types/node": "^24.11.0", |
||
| "@vercel/ncc": "0.38.4", | ||
| "eslint": "9.39.3", | ||
| "eslint-plugin-import": "2.32.0", | ||
|
Comment on lines
32
to
37
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I notice that pr-review and pr-summary define the same set of devDependencies. To reduce duplication and simplify future updates, consider hoisting these shared devDependencies into a root-level package.json using npm or Yarn workspaces. This way, you manage versions in one place instead of repeating them in each sub-package. Example root package.json: {
"workspaces": ["pr-review", "pr-summary"],
"devDependencies": {
"@eslint/js": "^9.39.3",
"@types/node": "^24.11.0",
"@vercel/ncc": "^0.38.4",
"eslint": "^9.39.3",
"eslint-plugin-import": "^2.32.0"
}
} |
||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,7 @@ | |
| }, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add an "engines": {
"node": ">=18.0.0 <20.0.0"
}, |
||
| "devDependencies": { | ||
| "@eslint/js": "9.39.3", | ||
| "@types/node": "24.10.15", | ||
| "@types/node": "24.11.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the other package, use a caret range for "@types/node": "^24.11.0", |
||
| "@vercel/ncc": "0.38.4", | ||
| "eslint": "9.39.3", | ||
| "eslint-plugin-import": "2.32.0", | ||
|
Comment on lines
31
to
36
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just like in pr-review, this package duplicates the same devDependencies. To avoid having to update both files when bumping versions, consider moving shared devDependencies to the monorepo root using npm/Yarn workspaces: {
"workspaces": ["pr-review", "pr-summary"],
"devDependencies": {
"@eslint/js": "^9.39.3",
"@types/node": "^24.11.0",
"@vercel/ncc": "^0.38.4",
"eslint": "^9.39.3",
"eslint-plugin-import": "^2.32.0"
}
} |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can improve environment consistency by declaring supported Node.js versions via the
enginesfield. This helps contributors and CI pipelines know which Node versions to use: