Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pr-review/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-review/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can improve environment consistency by declaring supported Node.js versions via the engines field. This helps contributors and CI pipelines know which Node versions to use:

"engines": {
  "node": ">=18.0.0 <20.0.0"
},

"devDependencies": {
"@eslint/js": "9.39.3",
"@types/node": "24.10.15",
"@types/node": "24.11.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using caret (^) version ranges for these devDependencies so that non-breaking patch and minor fixes are picked up automatically without manual bumps. For example, update the exact pin of @types/node to:

"@types/node": "^24.11.0",

"@vercel/ncc": "0.38.4",
"eslint": "9.39.3",
"eslint-plugin-import": "2.32.0",
Comment on lines 32 to 37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice that pr-review and pr-summary define the same set of devDependencies. To reduce duplication and simplify future updates, consider hoisting these shared devDependencies into a root-level package.json using npm or Yarn workspaces. This way, you manage versions in one place instead of repeating them in each sub-package.

Example root package.json:

{
  "workspaces": ["pr-review", "pr-summary"],
  "devDependencies": {
    "@eslint/js": "^9.39.3",
    "@types/node": "^24.11.0",
    "@vercel/ncc": "^0.38.4",
    "eslint": "^9.39.3",
    "eslint-plugin-import": "^2.32.0"
  }
}

Expand Down
8 changes: 4 additions & 4 deletions pr-summary/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pr-summary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an engines section to this package.json to clearly specify which Node.js versions are supported. This helps avoid version mismatches during development and in CI:

"engines": {
  "node": ">=18.0.0 <20.0.0"
},

"devDependencies": {
"@eslint/js": "9.39.3",
"@types/node": "24.10.15",
"@types/node": "24.11.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other package, use a caret range for @types/node to automatically receive compatible patch updates:

"@types/node": "^24.11.0",

"@vercel/ncc": "0.38.4",
"eslint": "9.39.3",
"eslint-plugin-import": "2.32.0",
Comment on lines 31 to 36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just like in pr-review, this package duplicates the same devDependencies. To avoid having to update both files when bumping versions, consider moving shared devDependencies to the monorepo root using npm/Yarn workspaces:

{
  "workspaces": ["pr-review", "pr-summary"],
  "devDependencies": {
    "@eslint/js": "^9.39.3",
    "@types/node": "^24.11.0",
    "@vercel/ncc": "^0.38.4",
    "eslint": "^9.39.3",
    "eslint-plugin-import": "^2.32.0"
  }
}

Expand Down