Skip to content

feat: Add of removal of recent search phrase from search box#20847

Draft
darvsorceix wants to merge 47 commits intodevelopfrom
CXCDS-14188
Draft

feat: Add of removal of recent search phrase from search box#20847
darvsorceix wants to merge 47 commits intodevelopfrom
CXCDS-14188

Conversation

@darvsorceix
Copy link
Contributor

@darvsorceix darvsorceix commented Nov 3, 2025

CXCDS-14188

@darvsorceix darvsorceix requested review from a team as code owners November 3, 2025 11:37
@github-actions github-actions bot marked this pull request as draft November 3, 2025 11:37
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

  • docs: Changes to documentation only
  • feat: New feature work
  • fix: Bug fixes
  • perf: Code improvements for performance
  • refactor: Code changes that are not bug fixes or features
  • style: Code style changes (e.g., whitespace, formatting)
  • test: Adding or updating tests
  • chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

feat: Add user authentication
fix: Resolve checkout bug
docs: Update API documentation

Merge is blocked until the PR title is corrected.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2025

🚨 PR Title Validation Failed 🚨

Your pull request title does not follow the required format. Please update it to match the expected pattern:

Expected format:
<type>: <subject>

Allowed Types

  • docs: Changes to documentation only
  • feat: New feature work
  • fix: Bug fixes
  • perf: Code improvements for performance
  • refactor: Code changes that are not bug fixes or features
  • style: Code style changes (e.g., whitespace, formatting)
  • test: Adding or updating tests
  • chore: Build, CI, scripts, configs, etc.

Example of a valid PR title

feat: Add user authentication
fix: Resolve checkout bug
docs: Update API documentation

Merge is blocked until the PR title is corrected.

@darvsorceix darvsorceix changed the title CXCDS-14188 Add of removal of recent search phrase from search box feat: add of removal of recent search phrase from search box CXCDS-14188 Nov 3, 2025
@darvsorceix darvsorceix marked this pull request as ready for review November 3, 2025 11:38
@darvsorceix darvsorceix changed the title feat: add of removal of recent search phrase from search box CXCDS-14188 feat: add of removal of recent search phrase from search box Nov 3, 2025
@darvsorceix darvsorceix changed the title feat: add of removal of recent search phrase from search box feat: Add of removal of recent search phrase from search box Nov 3, 2025
@cypress

This comment was marked as outdated.

@github-actions github-actions bot marked this pull request as draft November 3, 2025 12:45
@darvsorceix darvsorceix marked this pull request as ready for review November 3, 2025 12:45
@github-actions github-actions bot marked this pull request as draft November 10, 2025 15:32
@darvsorceix darvsorceix marked this pull request as ready for review November 11, 2025 11:13
@github-actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft November 11, 2025 11:22
@darvsorceix darvsorceix marked this pull request as ready for review November 11, 2025 11:31
@github-actions github-actions bot marked this pull request as draft November 12, 2025 11:50
@darvsorceix darvsorceix marked this pull request as ready for review November 12, 2025 11:56
@github-actions github-actions bot marked this pull request as draft November 12, 2025 11:56
…-14188

# Conflicts:
#	projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
#	projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts
@c5346163 c5346163 marked this pull request as ready for review February 18, 2026 10:17
@github-actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions github-actions bot marked this pull request as draft February 18, 2026 10:30
@c5346163 c5346163 marked this pull request as ready for review February 18, 2026 11:42
@c5346163 c5346163 requested a review from Pucek9 February 18, 2026 12:29
@github-actions github-actions bot marked this pull request as draft February 18, 2026 12:29
@c5346163 c5346163 marked this pull request as ready for review February 18, 2026 12:41
@c5346163
Copy link
Contributor

@darvsorceix, please provide QA steps. I have no idea how to see recent search phrases

You need to start with "cds" flag:
"start": "env-cmd --no-override -e dev,b2c,$SPA_ENV,cds nx serve storefrontapp --configuration=development",
image

image Thanks. I can see recent search phrases, but also some errors in the console, and no clear possibility

Console log fixed, as for "Clear" and "X" you need to set searchBoxRecentSearchesRemoval to true

image @darvsorceix QA steps didn't include the fact that consents need to be accepted.
BTW I still notice some issues, guess you didnt push latest update. My local changes: image

There have been some issues that I fixed. Now your local changes should provide the desired outcome.

event.preventDefault();
}
const recentSearches = (this.winRef.nativeWindow as ProfileTagWindowObject)
?.Y_TRACKING?.recentSearches;
Copy link
Contributor

@Pucek9 Pucek9 Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c5346163
If our core libraries need to know the details of the model from the integration library, without some generic abstraction, it occurs to me that maybe we should move this logic to the cds library after all.

What I mean is: creating a search box component in cds that extends the one from storefrontlib and connecting it to cms component mapping in cds.
Like a plug-in philosophy.
Then also we might even be able to avoid introducing feature toggles (or at least some of them).

@rmch91 What do you think?

@github-actions github-actions bot marked this pull request as draft February 19, 2026 09:28
@c5346163 c5346163 marked this pull request as ready for review February 19, 2026 10:25
@github-actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions bot marked this pull request as draft February 19, 2026 10:42
@c5346163 c5346163 marked this pull request as ready for review February 26, 2026 13:17
@github-actions github-actions bot marked this pull request as draft February 27, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants