feat: Add of removal of recent search phrase from search box#20847
feat: Add of removal of recent search phrase from search box#20847darvsorceix wants to merge 47 commits intodevelopfrom
Conversation
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
🚨 PR Title Validation Failed 🚨Your pull request title does not follow the required format. Please update it to match the expected pattern: Expected format: Allowed Types
Example of a valid PR title✅ ❌ Merge is blocked until the PR title is corrected. |
This comment was marked as outdated.
This comment was marked as outdated.
Merge Checks Failed |
…-14188 # Conflicts: # projects/core/src/features-config/feature-toggles/config/feature-toggles.ts # projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts
Merge Checks Failed |
Co-authored-by: Cursor <cursoragent@cursor.com>
There have been some issues that I fixed. Now your local changes should provide the desired outcome. |
| event.preventDefault(); | ||
| } | ||
| const recentSearches = (this.winRef.nativeWindow as ProfileTagWindowObject) | ||
| ?.Y_TRACKING?.recentSearches; |
There was a problem hiding this comment.
@c5346163
If our core libraries need to know the details of the model from the integration library, without some generic abstraction, it occurs to me that maybe we should move this logic to the cds library after all.
What I mean is: creating a search box component in cds that extends the one from storefrontlib and connecting it to cms component mapping in cds.
Like a plug-in philosophy.
Then also we might even be able to avoid introducing feature toggles (or at least some of them).
@rmch91 What do you think?
Merge Checks Failed |




CXCDS-14188