Skip to content

fix: handle null and empty file selections in file upload component#21199

Open
npapp-dev002 wants to merge 2 commits intodevelopfrom
fix/CXSPA-10472
Open

fix: handle null and empty file selections in file upload component#21199
npapp-dev002 wants to merge 2 commits intodevelopfrom
fix/CXSPA-10472

Conversation

@npapp-dev002
Copy link
Contributor

@npapp-dev002 npapp-dev002 commented Feb 27, 2026

Closes CXSPA-10472

QA steps:

  • Click "Import Products" hyperlink
  • Upload an invalid .xlsx file (e.g., a blank Excel file)
  • See expected error message "File is not parsable"
  • Click "Select File" again without closing the Import Products dialog
  • In the OS native file uploader, click the Cancel button (do not select any file)
  • Error message "File is required" should appear, instead of a success message
  • Console errors related to file parsing shouldn't appear
image

@npapp-dev002 npapp-dev002 requested a review from a team as a code owner February 27, 2026 10:41
@github-actions github-actions bot marked this pull request as draft February 27, 2026 10:42
@npapp-dev002 npapp-dev002 marked this pull request as ready for review February 27, 2026 10:52
@github-actions
Copy link
Contributor

E2E Tests Failed ❌

📸 Download Screenshots


Commit: 241b788

@github-actions
Copy link
Contributor

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@cypress
Copy link

cypress bot commented Feb 27, 2026

spartacus    Run #52037

Run Properties:  status check passed Passed #52037  •  git commit 3f60b8a58e ℹ️: Merge 8ea46c8227725297879dc1283e4bede3b64a6e05 into 3e71f7a9219000437defd3f7382a...
Project spartacus
Branch Review fix/CXSPA-10472
Run status status check passed Passed #52037
Run duration 13m 24s
Commit git commit 3f60b8a58e ℹ️: Merge 8ea46c8227725297879dc1283e4bede3b64a6e05 into 3e71f7a9219000437defd3f7382a...
Committer Norbert Papp
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 5
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@github-actions github-actions bot marked this pull request as draft February 27, 2026 13:19
@npapp-dev002 npapp-dev002 marked this pull request as ready for review February 27, 2026 13:39
@rmch91
Copy link
Contributor

rmch91 commented Feb 27, 2026

QA - OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants