Galen and Sheyna's Redesign of Loann and Marissa's Page #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Galen-Sheyna/Index.html
Outdated
Contributor
There was a problem hiding this comment.
Remove extra lines
Contributor
|
Just a few clean up issue, but pretty good. |
Galen-Sheyna/css/layout.css
Outdated
Author
There was a problem hiding this comment.
Is this the right way to change images via a media query? Sheyna and I were really wondering whether this was improperly hack-y or not. It... works on the browser. Do you know of any problems down the line or performance wise by inserting images via changing the "content" property?
Author
|
Great, thanks for going over our code, Dexter! We had just the one question about changing images via the "content: URL" property. Is it proper? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.