llama_decode_eagle latency issue solved#5
Merged
LeeHayun merged 5 commits intoSKKU-ESLAB:masterfrom Jul 2, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for an EAGLE input layer to address latency issues in the llama_decode_eagle function and updates related tensor loading, normalization, and RoPE settings. Key changes include:
- Introduce
LLM_TENSOR_LAYER_INPUT_EAGLEand map it in tensor loading and architecture definitions. - Comment out the redundant RMS normalization step in
llm_build_eagleto reduce overhead. - Adjust RoPE type mapping for the EAGLE architecture and update example integration under
examples/speculative-eagle.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/llama-model.cpp | Added handling for LLM_TENSOR_LAYER_INPUT_EAGLE and skipped norm. |
| src/llama-arch.h | Defined new enum value LLM_TENSOR_LAYER_INPUT_EAGLE. |
| src/llama-arch.cpp | Updated tensor info for LLM_TENSOR_EMBD_FC to use the new layer. |
| examples/speculative-eagle/* | Added complete example and build integration for EAGLE decoding. |
| examples/CMakeLists.txt | Registered the new speculative-eagle example in the build. |
Comments suppressed due to low confidence (4)
src/llama-arch.h:378
- The new enum value lacks a descriptive comment; add a brief explanation for
LLM_TENSOR_LAYER_INPUT_EAGLEso its purpose is clear to future maintainers.
LLM_TENSOR_LAYER_INPUT_EAGLE,
src/llama-arch.h:374
- New tensor layer functionality for EAGLE is not covered by existing tests; add unit tests for
load_tensorsand the EAGLE decode path to ensure correctness.
enum llm_tensor_layer {
examples/speculative-eagle/speculative-eagle.cpp:1
- [nitpick] Comments are written in Korean and English; for consistency and to accommodate a global contributor base, translate or unify comments in English.
//Tree-based EAGLE 구현 코드
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to read the contributing guidelines before submitting a PR
llama_decode_eagle 함수의 latency issue를 해결하였습니다.