Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades project dependencies and introduces comprehensive test coverage for the useDetectScroll hook. It includes dependency updates to Vite 7.3.1 and Vitest 2.1.9, along with a complete test suite.
Changes:
- Added Vitest testing framework with coverage configuration
- Renamed
types.tstouseDetectScroll.types.tsand updated all import references - Upgraded Vite from 6.4.1 to 7.3.1 and related dependencies
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Adds Vitest configuration with V8 coverage provider and appropriate exclusions |
| src/useDetectScroll.test.ts | Introduces comprehensive test suite covering scroll detection scenarios |
| src/useDetectScroll.ts | Updates import path from ./types to ./useDetectScroll.types |
| src/index.ts | Updates export path from ./types to ./useDetectScroll.types |
| package.json | Adds testing dependencies and upgrades Vite to version 7.3.1 |
| playground/package.json | Upgrades Vite and React plugin dependencies |
| .vscode/settings.json | Adds VSCode workspace configuration for ESLint and TypeScript |
| .prettierignore | Adds coverage directory and pnpm-lock.yaml to ignored files |
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.