Skip to content

utils: pxrad: fix too bright lightmap on emissive surfaces #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SNMetamorph merged 3 commits into from
Jan 7, 2026
Merged

utils: pxrad: fix too bright lightmap on emissive surfaces #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06fc706
Update qrad.cpp
ncuxonaT Jan 7, 2026
015dc19
Update qrad.cpp
ncuxonaT Jan 7, 2026
f5e2458
Update lightmap.cpp
ncuxonaT Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions utils/pxrad/lightmap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2235,14 +2235,7 @@ void CreateDirectLights( void )
g_directlights = dl;

if( !VectorIsNull( p->reflectivity ))
{
VectorScale( dl->intensity, 0.5 / M_PI, dl->intensity );
VectorMultiply( dl->intensity, p->reflectivity, dl->intensity );
}
else
{
VectorScale( dl->intensity, DIRECT_SCALE, dl->intensity );
}

if( !FBitSet( p->flags, PATCH_EMITLIGHT ) || g_fastmode )
dl->topatch = true;
Expand Down
11 changes: 5 additions & 6 deletions utils/pxrad/qrad.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,13 +448,7 @@ void InitWorldLightFromPatch( dworldlight_t *wl, patch_t *p )
VectorScale( wl->intensity, p->exposure, wl->intensity );

if( !VectorIsNull( p->reflectivity ))
{
VectorMultiply( wl->intensity, p->reflectivity, wl->intensity );
}
else
{
VectorScale( wl->intensity, DIRECT_SCALE, wl->intensity );
}

VectorCopy( GetPlaneFromFace( p->faceNumber )->normal, wl->normal );
wl->stopdot = wl->stopdot2 = 0.0f; // not used
Expand Down Expand Up @@ -985,6 +979,11 @@ void ReadLightFile( const char *filename, bool use_direct_path )
g = powf( g / 255.0f, 2.2f );
b = powf( b / 255.0f, 2.2f );

//moved here from CreateDirectLights and InitWorldLightFromPatch
r *= 0.5f / M_PI;
g *= 0.5f / M_PI;
b *= 0.5f / M_PI;

if( argCnt == 2 )
{
// eith 1+1 args, the R,G,B values are all equal to the first value
Expand Down
Loading