Fix: establish transaction and session before snapshot promotion/demotion#4899
Merged
Fix: establish transaction and session before snapshot promotion/demotion#4899
Conversation
erindru
reviewed
Jul 3, 2025
Collaborator
erindru
left a comment
erindru
left a comment
There was a problem hiding this comment.
I was going to comment saying that this needed a test, but I think that updating the failing tests (which are failing because the new calls are unexpected) to now expect the calls should cover this
treysp
force-pushed
the
trey/promote-demote-session
branch
2 times, most recently
from
baeb229 to
3e7facd
Compare
erindru
reviewed
Jul 3, 2025
treysp
force-pushed
the
trey/promote-demote-session
branch
5 times, most recently
from
9dc0521 to
94ce708
Compare
izeigerman
reviewed
Jul 7, 2025
izeigerman
reviewed
Jul 7, 2025
izeigerman
reviewed
Jul 7, 2025
treysp
force-pushed
the
trey/promote-demote-session
branch
3 times, most recently
from
266779f to
5f51295
Compare
izeigerman
approved these changes
Jul 7, 2025
treysp
force-pushed
the
trey/promote-demote-session
branch
from
5f51295 to
447394d
Compare
treysp
force-pushed
the
trey/promote-demote-session
branch
from
447394d to
db950e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.