fix!: make repr deterministic for fingerprinting#4925
Merged
Conversation
georgesittas
reviewed
Jul 7, 2025
eakmanrq
force-pushed
the
eakmanrq/make_repr_determinstic
branch
4 times, most recently
from
892699d to
46c0833
Compare
georgesittas
reviewed
Jul 8, 2025
eakmanrq
force-pushed
the
eakmanrq/make_repr_determinstic
branch
from
46c0833 to
cefe998
Compare
eakmanrq
force-pushed
the
eakmanrq/make_repr_determinstic
branch
from
cefe998 to
b6d5b68
Compare
georgesittas
approved these changes
Jul 8, 2025
Contributor
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Looks reasonable to me, nice!
eakmanrq
force-pushed
the
eakmanrq/make_repr_determinstic
branch
from
b6d5b68 to
78cdac7
Compare
georgesittas
pushed a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, models could show changes to
__sqlmesh__vars__even though there is not an actual change to the model. Looking at the code and it appears that the dictionary is not deterministic so this PR aims to address that shortcoming.