feat(lsp): return load time errors as diagnostics

[benfdking]

• adds path in places to make this as possible with
• refreshes well on typing

[Copilot]

Pull Request Overview

Adds support for surfacing load‐time configuration errors as LSP diagnostics in the editor.

• Extends ConfigError to carry a source Path and updates all raise_config_error/ConfigError calls to include file locations.
• Introduces context_error_to_diagnostic helpers in sqlmesh/lsp/errors.py and wires them into sqlmesh/lsp/main.py to convert ConfigError into LSP diagnostics.
• Refactors versioning: moves version_id out of LSPContext into the context‐state dataclasses (NoContext, ContextLoaded, ContextFailed).

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
sqlmesh/utils/errors.py	Added location field to ConfigError and updated raise_config_error to pass file paths.
sqlmesh/lsp/main.py	Injected version_id into context‐state, integrated context_error_to_diagnostic, and catch ConfigError for per‐file diagnostics.
sqlmesh/lsp/errors.py	New error‐to‐diagnostic mapping functions.
sqlmesh/lsp/context.py	Removed old version_id from LSPContext class.
sqlmesh/core/model/common.py	Changed validate_extra_and_required_fields and callers to pass path.
sqlmesh/core/model/definition.py	Updated validate_extra_and_required_fields calls to include path.
sqlmesh/core/loader.py	Propagated path into all ConfigError raises.

Comments suppressed due to low confidence (5)

sqlmesh/lsp/context.py:38

• The docstring still references a version_id property that was removed from LSPContext. Please update or remove this documentation block to avoid confusion.

    This is a version ID for the context. It is used to track changes to the context. It can be used to 

sqlmesh/lsp/main.py:230

• The early-return was changed to a pass, so for NoContext the method now continues and sends diagnostic refreshes even when no context exists. Consider restoring the return to avoid running downstream logic on a non-loaded context.

        if isinstance(self.context_state, NoContext):

sqlmesh/core/loader.py:1015

• The error message no longer includes the file path, which makes debugging harder. Consider restoring it, e.g., f"Failed to load macro file '{path}': {e}".

                    raise ConfigError(f"Failed to load macro file:  {e}", path)

sqlmesh/core/model/common.py:44

• You narrowed path from str | Path to only Path. If callers ever pass a string, this will break. Consider allowing both types or converting internally.

    path: t.Optional[Path] = None,

sqlmesh/lsp/main.py:780

• The previous broad except Exception: block was removed, so non-config errors will now escape this method and may crash the server. Consider adding a catch-all fallback below this block to return an empty diagnostic list.

        except ConfigError as config_error:

[themisvaltinos]

why did you change this here? it seems a bit dangerous

[benfdking]

It makes downstream much simpler, and nothing seems to be passing in a string?