feat(vscode): handling python errors well#4947
Merged
Conversation
552f8ba to
bc0ccd1
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling when loading Python config modules and updates VSCode extension tests to assert the new error messaging.
- Wraps the Python module import in
loader.pyin a try/except to raise a descriptiveConfigErroron import failures - Refactors an existing test to use an explicit
expectassertion and adds a new test for invalidconfig.pyin the sushi example
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vscode/extension/tests/broken_project.spec.ts | Refactored test assertion to use expect and added new test scenario |
| sqlmesh/core/config/loader.py | Wrapped Python import in try/except and raises ConfigError on failure |
Comments suppressed due to low confidence (2)
sqlmesh/core/config/loader.py:182
- Update the function docstring to document that
ConfigErroris raised when the Python module import fails.
def load_config_from_python_module(
sqlmesh/core/config/loader.py:187
- Add unit tests for
load_config_from_python_moduleto cover theConfigErrorpath when importing a broken Python file.
try:
| try: | ||
| with sys_path(module_path.parent): | ||
| config_module = import_python_file(module_path, module_path.parent) | ||
| except Exception as e: |
There was a problem hiding this comment.
Add exception chaining by raising the new ConfigError with from e (e.g., raise ConfigError(...) from e) to preserve the original traceback.
bc0ccd1 to
0770a17
Compare
themisvaltinos
approved these changes
Jul 11, 2025
Co-authored-by: Themis Valtinos <73662635+themisvaltinos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.