feat: Add Support For Microsoft Fabric Via SQL Endpoints#4950
feat: Add Support For Microsoft Fabric Via SQL Endpoints#4950mattiasthalen wants to merge 88 commits intoSQLMesh:mainfrom
Conversation
Co-authored-by: Mattias Thalén <bitter-polders0x@icloud.com>
…t/add-fabric-engine
…tion-tests' into feat/add-fabric-engine
|
@georgesittas ´tests/core/engine_adapter/test_mssql.py::test_varchar_workaround_to_max´ fails... is this redundant now that we have the varchar/char precision handling in sqlglot? |
This reverts commit cd4aa95.
…D to connection options for Fabric engine
There was a problem hiding this comment.
Nice work @mattiasthalen, we are getting there. The integration test suite passes on the Tobiko Fabric tenant.
I've left some feedback for your consideration. It would be good to get this merged with the other PR so we can be back to having a single unified PR for Fabric support
|
It looks like there is a regression in the unit tests: Do you run |
Sorry, forgot about that one. So used to running |
|
@mattiasthalen should this PR be closed and review done on the original PR ? |
|
Yeah, the only reason I did this PR was to hand you a preview |
This pull request introduces support for the Microsoft Fabric execution engine, including configuration, integration, documentation, and testing updates. The changes span multiple files to ensure Fabric is fully integrated into the system.
Fabric Engine Integration
FabricAdapterto handle Fabric-specific behavior, including theDELETE/INSERTstrategy forinsert_overwrite_by_conditionand disabling support for transactions and indexes. (sqlmesh/core/engine_adapter/fabric.py, sqlmesh/core/engine_adapter/fabric.pyR1-R49)FabricConnectionConfiginheriting fromMSSQLConnectionConfig, with default settings tailored for Fabric, such as thepyodbcdriver and autocommit enabled. (sqlmesh/core/config/connection.py, sqlmesh/core/config/connection.pyR1680-R1707)Documentation Updates
docs/integrations/engines/fabric.md, docs/integrations/engines/fabric.mdR1-R32)docs/integrations/overview.md, [1];mkdocs.yml, [2]Testing Enhancements
tests/core/engine_adapter/test_fabric.py, [1];tests/core/engine_adapter/integration/config.yaml, [2]FabricConnectionConfig, including ODBC connection string generation. (tests/core/test_connection_config.py, tests/core/test_connection_config.pyR1687-R1768)Dependency and Build Updates
pyodbcas a dependency for Fabric and included Fabric in test markers. (pyproject.toml, [1] [2]fabric-testtarget for running Fabric-specific tests. (Makefile, MakefileR176-R178)