chore(vscode): adding tests for bad projects#4957
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new end-to-end test to validate error handling and recovery for malformed model blocks in the VS Code extension.
- Expanded the import from
./utilsto includerunCommand - Introduced a new test that writes a bad model SQL, verifies the error in the Problems view, then removes the file to confirm context reload
Comments suppressed due to low confidence (3)
vscode/extension/tests/broken_project.spec.ts:262
- [nitpick] The test title is somewhat ambiguous. Consider renaming it to a more descriptive format such as
should recover from bad model block after removalfor clarity and consistency.
test('bad model block, then fixed', async ({ page, sharedCodeServer }) => {
vscode/extension/tests/broken_project.spec.ts:299
- Asserting on a partial error message can make the test brittle. Consider matching the full expected message or using a regex to guard against formatting changes.
.getByText("Required keyword: 'value' missing for")
vscode/extension/tests/broken_project.spec.ts:263
- This setup (temp directory creation, project copy, and interpreter specifier) is duplicated across tests. Consider extracting it into a shared helper or fixture to reduce duplication.
const tempDir = await fs.mkdtemp(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.