chore(vscode): add test for quickfix

[benfdking]

• also refactored the openProblemsView

[Copilot]

Pull Request Overview

Adds a new end-to-end test for the “noselectstar” quickfix and centralizes opening the Problems panel via a shared helper.

• Introduce openProblemsView utility in utils.ts
• Replace inline runCommand(page, 'View: Focus Problems') calls with openProblemsView across tests
• Add quickfix.spec.ts to validate the quickfix replaces SELECT * with explicit columns

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
vscode/extension/tests/utils.ts	Added openProblemsView helper with JSDoc
vscode/extension/tests/quickfix.spec.ts	New test for the noselectstar quickfix
vscode/extension/tests/diagnostics.spec.ts	Swapped runCommand for openProblemsView
vscode/extension/tests/broken_project.spec.ts	Replaced a single runCommand call with openProblemsView

Comments suppressed due to low confidence (1)

vscode/extension/tests/utils.ts:89

• [nitpick] The JSDoc for openProblemsView is missing a @param annotation for page; adding parameter documentation improves clarity for users of this helper.

/**

[Copilot]

Avoid using a fixed timeout for waiting; prefer waiting on a specific condition (e.g., expect.poll or waitForFunction) to detect when the file has been updated.

Suggested change

	await page.waitForTimeout(1_000)
	await page.waitForFunction(async () => {
	const content = await fs.readFile(modelPath, 'utf8');
	return content.includes('SELECT id, customer_id, waiter_id, start_ts, end_ts, event_date') && !content.includes('SELECT *');
	});

[Copilot]

[nitpick] The file is read and converted to string multiple times for assertions; consider reading once and storing the string in a variable to simplify and clarify the checks.

Suggested change

	const readUpdatedFile = await fs.readFile(modelPath)
	expect(readUpdatedFile.toString()).not.toContain('SELECT *')
	expect(readUpdatedFile.toString()).toContain(
	const readUpdatedFile = (await fs.readFile(modelPath)).toString()
	expect(readUpdatedFile).not.toContain('SELECT *')
	expect(readUpdatedFile).toContain(