Merged
Conversation
erindru
force-pushed
the
erin/cicd-bot-failure-output
branch
from
f44fbd4 to
dd6ee1c
Compare
erindru
force-pushed
the
erin/cicd-bot-failure-output
branch
from
dd6ee1c to
e9b2381
Compare
erindru
commented
Jul 14, 2025
|
|
||
| # capture_only = True: capture but dont print to console | ||
| # capture_only = False: capture and also print to console | ||
| self.warning_capture_only = kwargs.pop("warning_capture_only", False) |
Collaborator
Author
There was a problem hiding this comment.
I can't default these to true because the MarkdownConsole is used as the default console in CircleCI and a bunch of existing tests depend on these getting printed to console.
It's just the bot that wants to capture them and not print to console so it can give them special status in the Check output
themisvaltinos
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, if there was an error creating a PR environment, the output was a bit untidy:
Plan application failedmessage was duplicatedThis PR addresses these issues.
Before
After