Conversation
resolve_table() on themselves within a unit test
tobymao
approved these changes
Jul 15, 2025
themisvaltinos
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, having a Python model defined something like:
would work fine in the normal sense if you ran
sqlmesh plan.However, if you tried to create a unit test for it, you might get a
KeyErroron theresolve_table()call like:The cause is a subtle bug introduced in PR #4302 that switched the model-to-table mapping to be keyed by model name instead of normalized model fqn. The
resolve_table()call normalizes the argument that gets passed to it and expects it to be present in the mapping.However, things mostly kept working because that PR also added the contents of
model.depends_onto the mapping, which contains a list of normalized names. Sinceresolve_table()is usually called on upstream tables and not the current table, it would still resolve correctly.This PR switches the
TestExecutionContexttable mapping to be keyed by the original key, which is the same key thatContext.modelsuses.