Feat: Add signal listener and methods in scheduler#4983
Feat: Add signal listener and methods in scheduler#4983themisvaltinos wants to merge 3 commits intomainfrom
Conversation
themisvaltinos
force-pushed
the
themis/signals
branch
from
205bcff to
00d3802
Compare
sqlmesh/core/scheduler.py
Outdated
| def on_signal_register( | ||
| self, | ||
| snapshot_id: SnapshotId, | ||
| signals: t.Dict[str, t.Dict[str, str]], |
There was a problem hiding this comment.
Passing serialized arguments means that we design this interface for one use case and one use case only. I think it'd be more extendable if we just pass a Snapshot instance instead and let the implementation figure out what to do with it.
There was a problem hiding this comment.
Btw, shouldn't the registration be performed once for ALL snapshots with signals? And not the individual one?
There was a problem hiding this comment.
Btw, shouldn't the registration be performed once for ALL snapshots with signals? And not the individual one?
yes will revise to do it all snapshots at once and since passing snapshot instead it'd be easier
sqlmesh/core/scheduler.py
Outdated
| signal_name: str, | ||
| signal_index: int, | ||
| intervals: Intervals, | ||
| signal_kwargs: t.Dict[str, str], |
There was a problem hiding this comment.
Ditto: I'd rather just pass a snapshot
There was a problem hiding this comment.
revised to pass snapshot here instead. I'm not sure if you meant to also not pass the signal related args?
themisvaltinos
force-pushed
the
themis/signals
branch
from
00d3802 to
7ae9d39
Compare
|
Closing and deprioritising this for now to focus on other work |
3 participants
This adds the provisionally called
SignalListenerclass with methods which are called when signals are registered (on_signal_register), when a signal starts (on_signal_start) and when it finishes with success or failure (on_signal_end).