Skip to content

feat(vscode): startup extension on external models files#5012

Merged
benfdking merged 5 commits intomainfrom
trigger_start_external_models
Jul 24, 2025
Merged

feat(vscode): startup extension on external models files#5012
benfdking merged 5 commits intomainfrom
trigger_start_external_models

Conversation

@benfdking
Copy link
Contributor

@benfdking benfdking commented Jul 24, 2025

  • before if you were to open vscode and an external models file, the extension would not start automatically

@benfdking benfdking requested a review from Copilot July 24, 2025 12:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for automatically starting the VS Code extension when external models files (external_models.yaml or external_models.yml) are opened, addressing an issue where the extension wouldn't activate automatically for these file types.

  • Extends the Language Server Protocol (LSP) document selector to include external_models.yaml and external_models.yml files
  • Adds YAML language activation event to trigger extension startup
  • Includes comprehensive test coverage for both YAML file extensions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
vscode/extension/src/lsp/lsp.ts Extends LSP document selector to include external_models.yaml and external_models.yml patterns
vscode/extension/package.json Adds "onLanguage:yaml" activation event to automatically start extension for YAML files
vscode/extension/tests/external_models.spec.ts New test file verifying extension startup functionality for both .yaml and .yml external models files

benfdking and others added 4 commits July 24, 2025 13:36
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@benfdking benfdking merged commit 95b1f6e into main Jul 24, 2025
27 checks passed
@benfdking benfdking deleted the trigger_start_external_models branch July 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants