feat(vscode): startup extension on external models files#5012
Merged
feat(vscode): startup extension on external models files#5012
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for automatically starting the VS Code extension when external models files (external_models.yaml or external_models.yml) are opened, addressing an issue where the extension wouldn't activate automatically for these file types.
- Extends the Language Server Protocol (LSP) document selector to include external_models.yaml and external_models.yml files
- Adds YAML language activation event to trigger extension startup
- Includes comprehensive test coverage for both YAML file extensions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| vscode/extension/src/lsp/lsp.ts | Extends LSP document selector to include external_models.yaml and external_models.yml patterns |
| vscode/extension/package.json | Adds "onLanguage:yaml" activation event to automatically start extension for YAML files |
| vscode/extension/tests/external_models.spec.ts | New test file verifying extension startup functionality for both .yaml and .yml external models files |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
georgesittas
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.