Merged
Conversation
benfdking
force-pushed
the
refactoring_the_context_tests
branch
from
a4884f0 to
edbe39a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors test files to eliminate code duplication by introducing a centralized utility function waitForLoadedSQLMesh to replace repeated inline calls to page.waitForSelector('text=Loaded SQLMesh Context').
- Extract repeated wait selector logic into a reusable utility function
- Update all test files to use the new
waitForLoadedSQLMeshfunction - Standardize the message text format in the LSP implementation
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vscode/extension/tests/utils.ts | Adds new waitForLoadedSQLMesh utility function |
| sqlmesh/lsp/main.py | Standardizes message format and removes folder path parameter |
| vscode/extension/tests/*.spec.ts | Updates 17 test files to use the new utility function |
| def loaded_sqlmesh_message(ls: LanguageServer) -> None: | ||
| ls.show_message( | ||
| f"Loaded SQLMesh context from {folder}", | ||
| f"Loaded SQLMesh Context", |
There was a problem hiding this comment.
The message text 'Loaded SQLMesh Context' is inconsistent with the test selector pattern 'text=Loaded SQLMesh context' (lowercase 'context'). This will cause test failures as the selector won't match the actual message.
Suggested change
| f"Loaded SQLMesh Context", | |
| f"Loaded SQLMesh context", |
VaggelisD
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.