Conversation
0a989a2 to
15e226f
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the LSP references function to detect and handle unregistered external models that are not defined in the configuration files. Previously, the system would ignore references to external models that weren't registered, but now it creates specific reference objects for these unregistered models.
- Added support for detecting unregistered external models as LSP references
- Made the
urifield optional inLSPExternalModelReferenceto accommodate unregistered models - Updated LSP handlers to handle references with null URIs appropriately
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
sqlmesh/lsp/reference.py |
Made uri field optional in LSPExternalModelReference and added logic to create references for unregistered external models |
sqlmesh/lsp/main.py |
Updated goto_definition and find_references handlers to check for null URIs before processing |
tests/lsp/test_reference_external_model.py |
Added test for unregistered external model detection and updated existing test to handle optional URI |
tests/lsp/test_reference.py |
Updated test assertions to handle optional URI field |
Comments suppressed due to low confidence (1)
tests/lsp/test_reference_external_model.py:50
- The function name 'test' is too generic and doesn't describe what it tests. Consider renaming it to 'test_reference_unregistered_external_model' to be more descriptive.
def test(tmp_path: Path):
15e226f to
9949faf
Compare
VaggelisD
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.