Skip to content

fix(lsp): notification would now show #5024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Jul 25, 2025
Merged

fix(lsp): notification would now show #5024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sqlmesh/lsp/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,7 @@ def _ensure_context_in_folder(self, folder_path: t.Optional[Path] = None) -> Non
config_path = workspace_folder / f"config.{ext}"
if config_path.exists():
if self._create_lsp_context([workspace_folder]):
loaded_sqlmesh_message(self.server)
return

# Then , check the provided folder recursively
Expand All @@ -835,6 +836,7 @@ def _ensure_context_in_folder(self, folder_path: t.Optional[Path] = None) -> Non
config_path = path / f"config.{ext}"
if config_path.exists():
if self._create_lsp_context([path]):
loaded_sqlmesh_message(self.server)
return

path = path.parent
Expand All @@ -860,15 +862,13 @@ def _create_lsp_context(self, paths: t.List[Path]) -> t.Optional[LSPContext]:
try:
if isinstance(self.context_state, NoContext):
context = self.context_class(paths=paths)
loaded_sqlmesh_message(self.server)
elif isinstance(self.context_state, ContextFailed):
if self.context_state.context:
context = self.context_state.context
context.load()
else:
# If there's no context (initial creation failed), try creating again
context = self.context_class(paths=paths)
loaded_sqlmesh_message(self.server)
else:
context = self.context_state.lsp_context.context
context.load()
Expand Down