feat: allow linter to return multiple violations

[benfdking]

• also printed the line numbers

❯ sqlmesh lint
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/customers.sql:
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/marketing.sql:
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/active_customers.sql:
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/customer_revenue_lifetime.sql:
 - nomissingaudits at line 6: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/blueprint.sql:
 - nomissingowner: All models should have an owner specified.
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/blueprint.sql:
 - nomissingowner: All models should have an owner specified.
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/customer_revenue_by_day.sql:
 - nomissingaudits at line 2: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/latest_order.sql:
 - nomissingowner: All models should have an owner specified.
 - nomissingaudits at line 1: Model `audits` must be configured to test data quality.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/external_models.yaml:
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/external_models/model1/model1.yaml:
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/external_models/model2/model2.yaml:
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/order_items.py:
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/orders.py:
 - nomissingaudits: Model `audits` must be configured to test data quality.
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/raw_marketing.py:
 - nomissingaudits: Model `audits` must be configured to test data quality.
 - nomissingowner: All models should have an owner specified.
Linter errors for /Users/benjaminking/Developer/sqlmesh/examples/sushi/models/items.py:
 - nomissingowner: All models should have an owner specified.
Error: Linter detected errors in the code. Please fix them before proceeding.

[Copilot]

Pull Request Overview

This PR enhances the SQLMesh linter to support multiple violations per rule and improves violation reporting by adding line numbers and sorting. The changes enable linter rules to return multiple violations in a single check and provide clearer output with line-based sorting.

• Modified the Rule.check_model method signature to return either a single violation or a list of violations
• Updated violation processing logic to handle both single violations and lists of violations
• Enhanced violation display formatting to include line numbers and sort violations by line and rule name

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
sqlmesh/core/linter/rule.py	Updates abstract method signature to allow returning multiple violations
sqlmesh/core/linter/definition.py	Adds logic to handle both single violations and lists from rule checks
sqlmesh/core/console.py	Enhances violation display with line numbers and sorting functionality

[izeigerman]

Need more context to understand this. How can a single model violate the same rule more than once?

[izeigerman]

Ah, I guess in case of multiple missing external models we want to emit multiple violations.

[izeigerman]

This looks wrong. Are we adding the same violation twice? Haven't we added it on line 112 already?

[benfdking]

No it turns the RuleViolation into a t.List[RulationViolation] before adding it. and if it's None it doesn't get extended.