Chore: do not fail if sqlglot optimization rules raise an exception#5040
Closed
georgesittas wants to merge 1 commit intomainfrom
Closed
Chore: do not fail if sqlglot optimization rules raise an exception#5040georgesittas wants to merge 1 commit intomainfrom
georgesittas wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
Discussed offline– closing this because users have the option of setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, rendering may fail without raising a
SqlglotError, e.g., if there is a bug and one ofqualify,annotate_typesorsimplifyfail. I believe logging those errors is helpful, but failing to load altogether seems too abrupt. This PR intercepts those exceptions and logs a warning instead of re-raising them.The tradeoff here is that we're reducing the likelyhood of seeing these errors as they happen in the wild, since they're now going to only emit a warning. I'm personally happy with this vs running to put out fires.