Fix!: normalize blueprint variables#5045
Merged
georgesittas merged 3 commits intomainfrom Jul 31, 2025
Merged
Conversation
izeigerman
reviewed
Jul 28, 2025
izeigerman
reviewed
Jul 28, 2025
izeigerman
reviewed
Jul 28, 2025
92b56c1 to
6201a76
Compare
a9fc861 to
73433d0
Compare
izeigerman
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following model fails to load today, because blueprint variables are not normalized:
This PR aims to address this issue. I also added a migration script that normalizes all existing blueprint
variable keys in the
python_env, unless there are keys that collide when normalized. In that case, weraise an
AssertionErrorto avoid messing up the state. This allows the user to rename their blueprintvariables in order to avoid this issue and then re-run the migration.