Skip to content

fix(vscode): improve registering of lsp in extension#5056

Merged
benfdking merged 1 commit intomainfrom
improve_singleton_registering_of_extension
Jul 29, 2025
Merged

fix(vscode): improve registering of lsp in extension#5056
benfdking merged 1 commit intomainfrom
improve_singleton_registering_of_extension

Conversation

@benfdking
Copy link
Contributor

@benfdking benfdking commented Jul 29, 2025 •
edited
Loading

  • registers the LSPClient once
  • allows it to be restarted
  • uses singleton more robustly
  • cleans up the LSP itself on stop properly by using dispose

@benfdking benfdking merged commit 9238534 into main Jul 29, 2025
26 of 27 checks passed
@benfdking benfdking deleted the improve_singleton_registering_of_extension branch July 29, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@themisvaltinos themisvaltinos themisvaltinos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benfdking @themisvaltinos