feat: no missing external model provides fix#5058
Merged
Conversation
bc1653a to
c8acb31
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements an automatic fix feature for the "no missing external models" linter rule that adds missing external models to the external_models.yaml file. The fix intelligently handles whether the file ends with a newline or not to properly format the YAML addition.
- Adds automatic fix generation for missing external models in the linter
- Removes LSP-specific code for external model management (code lenses and commands)
- Adds comprehensive test coverage for the fix functionality with different file ending scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sqlmesh/core/linter/rules/builtin.py | Implements create_fix method to automatically add missing external models to YAML file |
| tests/core/linter/test_builtin.py | Adds test cases for fix functionality with files ending/not ending in newlines |
| sqlmesh/lsp/main.py | Removes external model update commands and code lens features |
| sqlmesh/lsp/context.py | Removes LSP-specific external model update functionality |
c8acb31 to
275a770
Compare
izeigerman
approved these changes
Jul 29, 2025
275a770 to
a7604f9
Compare
- nomissingexternalmodels lint rule now returns a fix that can be used by the IDE
7a002e9 to
e5e0680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
external_models.yamlfile. In this case it doesn't suggest the fix.