Closed
Conversation
d4b36ff to
85d0ed1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Terminal console, a progress bar is displayed when SQLMesh is evaluating models.
The bar includes elapsed time over all models being evaluated, but in some scenarios that timer resets before all models had been evaluated.
The cause of the timer reset was:
start_evaluation_progressmethod creates the progress bar and assigns the "task" containing the timer. The task is assigned aTaskIDthat is stored in a console instance field for later usage.update_snapshot_evaluation_progressmethod incrementally updates the progress bar as model evaluations complete. That includes updating the task containing the timer, which requires the Task ID stored previously.TaskID(0)instead. It appears that this fallback resets the timer, even if the originally assigned task ID was 0.This PR fixes that issue by conditioning the update call on the existence of a progress bar task ID.