feat: allow empty external models file#5061
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error that occurs when external models files are empty, allowing users to create empty YAML files without encountering a confusing "None is non-iterable" error. This improves the user experience when initially setting up external models in VS Code.
- Adds handling for empty YAML files by checking if the parsed content is None
- Returns an empty list instead of attempting to iterate over None
- Refactors the YAML loading to avoid reading the file twice
georgesittas
approved these changes
Jul 29, 2025
benfdking
force-pushed
the
fix_empty_external_model
branch
from
c3103b1 to
b94a40e
Compare
- before you would get an error saying None is non-iterable - was just slightly confusing when you first create the file in vscode and we show a confusing error
benfdking
force-pushed
the
fix_empty_external_model
branch
from
b94a40e to
465e052
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in vscode and we show a confusing error