Skip to content

Chore: Pin dateparser version#5063

Merged
erindru merged 1 commit intomainfrom
erin/fix-tests
Jul 29, 2025
Merged

Chore: Pin dateparser version#5063
erindru merged 1 commit intomainfrom
erin/fix-tests

Conversation

@erindru
Copy link
Collaborator

@erindru erindru commented Jul 29, 2025

dateparser==1.2.2 seems to cause some date-related tests to fail

This pins it to <= 1.2.1 which fixes things on a fresh venv. Note that ~= 1.2.1 still causes 1.2.2 to get resolved which causes the tests to fail on a fresh venv

@tobymao
Copy link
Contributor

tobymao commented Jul 29, 2025

what's the issue?

@tobymao
Copy link
Contributor

tobymao commented Jul 29, 2025

1.2.2 is an important release because it contains performance fixes i made

@erindru
Copy link
Collaborator Author

erindru commented Jul 29, 2025

Still working on pinning down exactly what causes it, I just wanted to provide an option to move forward in the short term.

Basically, this function started returning None in some situations again.

It appears to be nuanced, im trying to track down the root cause which may be in a transitive dependency.

  • Fresh venv, dateparser==1.2.2 resolved - tests fail
  • Fresh venv, dateparser==1.2.1 resolved - tests pass
  • My existing development venv, manually pip install --upgrade dateparser==1.2.2 - tests pass for some reason

@erindru
Copy link
Collaborator Author

erindru commented Jul 29, 2025

Merging this to unblock the pipeline in the short term, i'll raise another PR when I figure out what the root cause is

@erindru erindru merged commit 854379d into main Jul 29, 2025
27 checks passed
@erindru erindru deleted the erin/fix-tests branch July 29, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants