Conversation
Contributor
|
what's the issue? |
Contributor
|
1.2.2 is an important release because it contains performance fixes i made |
Collaborator
Author
|
Still working on pinning down exactly what causes it, I just wanted to provide an option to move forward in the short term. Basically, this function started returning It appears to be nuanced, im trying to track down the root cause which may be in a transitive dependency.
|
benfdking
approved these changes
Jul 29, 2025
Collaborator
Author
|
Merging this to unblock the pipeline in the short term, i'll raise another PR when I figure out what the root cause is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dateparser==1.2.2seems to cause some date-related tests to failThis pins it to
<= 1.2.1which fixes things on a fresh venv. Note that~= 1.2.1still causes1.2.2to get resolved which causes the tests to fail on a fresh venv