Skip to content

feat(vscode): allow the lsp loaded to be specified#5070

Merged
benfdking merged 2 commits intomainfrom
specify_lsp
Jul 30, 2025
Merged

feat(vscode): allow the lsp loaded to be specified#5070
benfdking merged 2 commits intomainfrom
specify_lsp

Conversation

@benfdking
Copy link
Contributor

@benfdking benfdking commented Jul 30, 2025

  • allow the extension to specify the lsp script entrypoint
  • tests the different scenarios
    • absolute entrypoint
    • relative entrypoint
    • entrypoint with arguments

- allow the extension to specify the lsp script entrypoint
@benfdking benfdking requested a review from Copilot July 30, 2025 17:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds LSP entrypoint configuration support to the VSCode SQLMesh extension, allowing users to specify a custom LSP server command instead of using the default sqlmesh_lsp binary.

  • Adds a new sqlmesh.lspEntrypoint configuration option that accepts a command with optional arguments
  • Modifies the LSP execution logic to prioritize the configured entrypoint over the default discovery
  • Includes comprehensive test coverage for absolute paths, relative paths, and entrypoints with arguments

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Adds the new sqlmesh.lspEntrypoint configuration property
src/utilities/config.ts Implements parsing logic for the LSP entrypoint configuration
src/utilities/sqlmesh/sqlmesh.ts Updates LSP execution to use configured entrypoint when available
tests/configuration.spec.ts Adds test cases covering different entrypoint configuration scenarios

@benfdking benfdking enabled auto-merge (squash) July 30, 2025 19:57
@benfdking benfdking merged commit b32f3ae into main Jul 30, 2025
26 checks passed
@benfdking benfdking deleted the specify_lsp branch July 30, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants