feat(vscode): allow the lsp loaded to be specified#5070
Merged
Conversation
- allow the extension to specify the lsp script entrypoint
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds LSP entrypoint configuration support to the VSCode SQLMesh extension, allowing users to specify a custom LSP server command instead of using the default sqlmesh_lsp binary.
- Adds a new
sqlmesh.lspEntrypointconfiguration option that accepts a command with optional arguments - Modifies the LSP execution logic to prioritize the configured entrypoint over the default discovery
- Includes comprehensive test coverage for absolute paths, relative paths, and entrypoints with arguments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Adds the new sqlmesh.lspEntrypoint configuration property |
| src/utilities/config.ts | Implements parsing logic for the LSP entrypoint configuration |
| src/utilities/sqlmesh/sqlmesh.ts | Updates LSP execution to use configured entrypoint when available |
| tests/configuration.spec.ts | Adds test cases covering different entrypoint configuration scenarios |
izeigerman
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.