Conversation
Contributor
benfdking
commented
Jul 30, 2025
benfdking
commented
- some of these were flaky but this should fix them and make them more reliable
- as working on pieces that affect this bit of the codebase we want these tests working
- some of these were flaky but this should fix them and make them more reliable - as working on pieces that affect this bit of the codebase we want these tests working
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables flaky tests in the VS Code extension test suite by improving test reliability through better element selection and fixing timing issues.
- Replaces brittle CSS selector with more robust role-based element selection
- Improves file name matching by using basename instead of full path
- Re-enables a previously skipped test that was experiencing flakiness
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vscode/extension/tests/utils.ts | Updates file opening utility to use more reliable element selection and file name matching |
| vscode/extension/tests/bad_setup.spec.ts | Re-enables a previously skipped test case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.