Skip to content

chore(vscode): enabling more tests #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Jul 30, 2025
Merged

chore(vscode): enabling more tests #5073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
95 changes: 30 additions & 65 deletions vscode/extension/tests/lineage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import {
* Helper function to launch VS Code and test lineage with given project path config
*/
async function testLineageWithProjectPath(page: Page): Promise<void> {
await page.waitForLoadState('networkidle')
await page.waitForLoadState('domcontentloaded')
await openLineageView(page)
await waitForLoadedSQLMesh(page)
}
Expand All @@ -37,120 +35,87 @@ test('Lineage panel renders correctly - no project path config (default)', async
await testLineageWithProjectPath(page)
})

test.skip('Lineage panel renders correctly - relative project path', async ({
test('Lineage panel renders correctly - relative project path', async ({
page,
sharedCodeServer,
tempDir,
}) => {
const workspaceDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-workspace-'),
)
const projectDir = path.join(workspaceDir, 'projects', 'sushi')
const projectDir = path.join(tempDir, 'projects', 'sushi')
await fs.copy(SUSHI_SOURCE_PATH, projectDir)

const context = await startCodeServer({
tempDir: workspaceDir,
})

const settings = {
'sqlmesh.projectPath': './projects/sushi',
'python.defaultInterpreterPath': context.defaultPythonInterpreter,
'python.defaultInterpreterPath': sharedCodeServer.defaultPythonInterpreter,
}
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
await fs.writeJson(
path.join(workspaceDir, '.vscode', 'settings.json'),
settings,
{ spaces: 2 },
)
await fs.ensureDir(path.join(tempDir, '.vscode'))
await fs.writeJson(path.join(tempDir, '.vscode', 'settings.json'), settings, {
spaces: 2,
})

try {
await openServerPage(page, workspaceDir, sharedCodeServer)
await openServerPage(page, tempDir, sharedCodeServer)
await testLineageWithProjectPath(page)
} finally {
await fs.remove(workspaceDir)
await fs.remove(tempDir)
}
})

test.skip('Lineage panel renders correctly - absolute project path', async ({
test('Lineage panel renders correctly - absolute project path', async ({
page,
tempDir,
sharedCodeServer,
}) => {
const workspaceDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-workspace-'),
)
const projectDir = path.join(workspaceDir, 'projects', 'sushi')
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
// Copy the sushi project to temporary directory
const projectDir = path.join(tempDir, 'projects', 'sushi')
await fs.ensureDir(path.join(tempDir, '.vscode'))
await fs.copy(SUSHI_SOURCE_PATH, projectDir)
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
const context = await startCodeServer({
tempDir: workspaceDir,
})

const settings = {
'sqlmesh.projectPath': projectDir,
'python.defaultInterpreterPath': context.defaultPythonInterpreter,
'python.defaultInterpreterPath': sharedCodeServer.defaultPythonInterpreter,
}
await fs.writeJson(
path.join(workspaceDir, '.vscode', 'settings.json'),
settings,
{ spaces: 2 },
)
await fs.writeJson(path.join(tempDir, '.vscode', 'settings.json'), settings, {
spaces: 2,
})

try {
await openServerPage(page, tempDir, sharedCodeServer)
await testLineageWithProjectPath(page)
} finally {
await stopCodeServer(context)
}
await openServerPage(page, tempDir, sharedCodeServer)
await testLineageWithProjectPath(page)
})

test.skip('Lineage panel renders correctly - relative project outside of workspace', async ({
test('Lineage panel renders correctly - relative project outside of workspace', async ({
page,
sharedCodeServer,
tempDir,
}) => {
const tempFolder = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-workspace-'),
)
const projectDir = path.join(tempFolder, 'projects', 'sushi')
const projectDir = path.join(tempDir, 'projects', 'sushi')
await fs.copy(SUSHI_SOURCE_PATH, projectDir)

const workspaceDir = path.join(tempFolder, 'workspace')
const workspaceDir = path.join(tempDir, 'workspace')
await fs.ensureDir(workspaceDir)
const context = await startCodeServer({
tempDir: workspaceDir,
})

const settings = {
'sqlmesh.projectPath': './../projects/sushi',
'python.defaultInterpreterPath': context.defaultPythonInterpreter,
'python.defaultInterpreterPath': sharedCodeServer.defaultPythonInterpreter,
}
await fs.ensureDir(path.join(workspaceDir, '.vscode'))
await fs.writeJson(
path.join(workspaceDir, '.vscode', 'settings.json'),
settings,
{ spaces: 2 },
)

try {
await openServerPage(page, tempDir, sharedCodeServer)
await testLineageWithProjectPath(page)
} finally {
await stopCodeServer(context)
}
await openServerPage(page, workspaceDir, sharedCodeServer)
await testLineageWithProjectPath(page)
})

test.skip('Lineage panel renders correctly - absolute path project outside of workspace', async ({
test('Lineage panel renders correctly - absolute path project outside of workspace', async ({
page,
sharedCodeServer,
tempDir,
}) => {
const tempFolder = await fs.mkdtemp(
path.join(os.tmpdir(), 'vscode-test-workspace-'),
)
const projectDir = path.join(tempFolder, 'projects', 'sushi')
const projectDir = path.join(tempDir, 'projects', 'sushi')
await fs.copy(SUSHI_SOURCE_PATH, projectDir)

const workspaceDir = path.join(tempFolder, 'workspace')
const workspaceDir = path.join(tempDir, 'workspace')
await fs.ensureDir(workspaceDir)

const settings = {
Expand Down