Fix: Reinstate dateparser==1.2.2 with a workaround for the upstream issue#5076
Closed
Fix: Reinstate dateparser==1.2.2 with a workaround for the upstream issue#5076
Conversation
erindru
commented
Jul 30, 2025
| "croniter", | ||
| "duckdb>=0.10.0,!=0.10.3", | ||
| "dateparser<=1.2.1", | ||
| "dateparser>=1.2.2", |
Collaborator
Author
There was a problem hiding this comment.
This pin forces SQLMesh to use the version of dateparser that contains the performance enhancements (which dont exist in any other version), but also the parsing regression that this PR provides a workaround for
8750370 to
eba8345
Compare
eba8345 to
05ba4a1
Compare
Collaborator
Author
|
Closing in favour of keeping the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dateparser==1.2.2introduced a regression that essentially causes the following to fail:This breaks a bunch of tests in SQLMesh.
However,
dateparser==1.2.2also introduced a cache that shaves several seconds off SQLMesh startup time which can add up over many invocations of SQLMesh.So this PR adds a workaround for the upstream regression until it can be resolved upstream. The workaround is simply deleting the
dateparser_tz_cache.pklpickle file that is distributed withdateparser==1.2.2and allowing it to be regenerated on first load.However, we need to be careful just to delete the one that was distributed from upstream and not one that has been generated locally, since it's the source of the startup time performance improvement.