Fix(athena): Properly extend Athena dialect#5077
Merged
Conversation
erindru
commented
Jul 31, 2025
.circleci/continue_config.yml
Outdated
| - redshift | ||
| - bigquery | ||
| - clickhouse-cloud | ||
| #- snowflake |
Collaborator
Author
There was a problem hiding this comment.
todo: revert prior to merge
Contributor
|
Thanks for taking this on. I'm surprised this wasn't caught by any tests. |
georgesittas
approved these changes
Jul 31, 2025
Collaborator
Author
Me too. I think it was partially working for the parser because It was the Generator path that was getting missed because:
We also have a tendency to assume in the test suite that if it works for duckdb, it works for everything |
This reverts commit 8cfb717.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5065
I think Athena has been broken since SQLMesh
v0.198.0were we upgraded SQLGlot tov26.32.0.With that upgrade:
<dialect>.Parser,<dialect>.TokenizeretcThis PR includes the extra set of top-level classes when extending the Athena dialect and adds a test that checks
MODEL (...)can be roundtripped across every dialect