feat(vscode): multi project for vscode#5084
Merged
Conversation
50a105a to
2fe5f5c
Compare
26a7253 to
c65470b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements multi-project support for the VSCode SQLMesh extension by allowing users to configure multiple project paths instead of a single project path. The extension now passes these paths to the Language Server Protocol (LSP) during initialization, enabling the LSP to handle multiple SQLMesh projects simultaneously.
Key changes:
- Updated configuration from
sqlmesh.projectPath(string) tosqlmesh.projectPaths(array) - Modified LSP initialization to pass project paths as initialization options
- Added support for multi-project handling in the SQLMesh Language Server
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vscode/extension/package.json | Updates configuration schema to accept array of project paths |
| vscode/extension/src/utilities/config.ts | Refactors configuration handling to support multiple project paths |
| vscode/extension/src/lsp/lsp.ts | Passes resolved project paths to LSP during initialization |
| vscode/extension/src/utilities/sqlmesh/sqlmesh.ts | Updates function calls to use new resolved path structure |
| sqlmesh/lsp/main.py | Adds support for receiving and handling multiple project paths |
| vscode/extension/tests/utils.ts | Adds test utility for multi-project example path |
| vscode/extension/tests/multi_project.spec.ts | Adds test case for multi-project functionality |
| vscode/extension/tests/lineage.spec.ts | Updates existing tests to use new array-based configuration |
| examples/multi/.vscode/settings.json | Provides example configuration for multi-project setup |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
9181010 to
c65470b
Compare
themisvaltinos
approved these changes
Aug 14, 2025
Contributor
themisvaltinos
left a comment
There was a problem hiding this comment.
lgtm, maybe have a small section in vscode.md that explains that the project paths need to be added in the settings to enable this
c65470b to
458a858
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.