Fix: clean signal registry before loading signals for the given project#5088
Merged
izeigerman merged 1 commit intoSQLMesh:mainfrom Aug 1, 2025
Merged
Conversation
z3z1ma
force-pushed
the
fix/clear-registry-before-load-signals
branch
from
6ed8333 to
8ecc56e
Compare
izeigerman
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signals for a given project are registered explicitly by importing files in
./signals. In macros, the global registry of "standard macros" is copied out at the beginning of load, and user defined macros are loaded, then registry is set back to its old state. We do the same here now.the issue is when you copy paste a signal from project A to project B
https://github.com/z3z1ma/sqlmesh/blob/6ed83334ef95cc23146eef6ff76731d1252e6665/sqlmesh/utils/__init__.py#L135-L140
this code will not raise a ValueError in the unique key dict subtly masking the fact that the signal that will persist is from project A. this mean project B in metaprogramming will not share subpath with module and will be registered as an import payload