Skip to content

Chore: Introduce Claude subagents to the repo#5093

Merged
izeigerman merged 4 commits intomainfrom
chore-add-claude-subagents
Aug 6, 2025
Merged

Chore: Introduce Claude subagents to the repo#5093
izeigerman merged 4 commits intomainfrom
chore-add-claude-subagents

Conversation

@izeigerman
Copy link
Collaborator

Introduces the following subagents to this repo:

  • developer - to implement features and fix issues
  • code-reviewer - to review the code produced by the developer agent
  • technical-writer - to update the docs

@izeigerman izeigerman requested a review from a team August 5, 2025 01:02
@izeigerman izeigerman force-pushed the chore-add-claude-subagents branch 5 times, most recently from 0e42d92 to 4c42512 Compare August 5, 2025 06:02
Comment on lines +4 to +5
tools: Glob, Grep, LS, Read, NotebookRead, WebFetch, TodoWrite, WebSearch, Bash
model: sonnet
Copy link
Collaborator

@eakmanrq eakmanrq Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is for all agents - should we not include tools/model and let the main thread determine what is allowed? I don't think we are ready to be opinionated on a detail like that for users.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This header is a part of the Claude agent definition format. This is metadata I believe and is not part of the prompt. Just like color.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the docs:

You have two options for configuring tools:

Omit the tools field to inherit all tools from the main thread (default), including MCP tools
Specify individual tools as a comma-separated list for more granular control (can be edited manually or via /agents)

I read that as the tools provided here override what I have already approved in my main thread.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. The reason tools are outlined here is because some of the agents are read-only (eg. the code-reviewer one) and this is what captured here.

@izeigerman izeigerman force-pushed the chore-add-claude-subagents branch from 4c42512 to 61f8a4e Compare August 5, 2025 16:36
@sungchun12
Copy link
Contributor

@izeigerman For the public that will use these sub-agents, how did you verify these behave as expected?

@izeigerman
Copy link
Collaborator Author

izeigerman commented Aug 5, 2025

@sungchun12 if you can suggest some concrete techniques for evaluating this I'm happy to try them. Ideally, the process would involve having a pool of existing issues which we feed into Claude Code before and after prompt changes. I haven't performed this kind of evaluation.

I did feed it a few open issues and saw it perform well with only small comments on my end. I tried the same issues before my changes and it did perform (subjectively) worse. Though, neither the size of the pool of issues nor my evaluation criteria were sufficient imo.

We should consider developing a series of synthetic tasks against this repo which we can use to evaluate changes to these prompts. We'd also need to develop evaluation criteria. Both tasks are non-trivial.

In the meantime, I suggest people try and use it and then extend the prompts as they agents struggling or running into issues.

@sungchun12
Copy link
Contributor

The heuristic is enough for me. We'll let people try it out in the wild and iterate from there!

@izeigerman izeigerman force-pushed the chore-add-claude-subagents branch from d76def8 to 97ffa96 Compare August 5, 2025 17:34
@izeigerman izeigerman merged commit eb4c0b4 into main Aug 6, 2025
27 checks passed
@izeigerman izeigerman deleted the chore-add-claude-subagents branch August 6, 2025 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants