Feat!: Decouple forward-only from change categorization#5110
Merged
izeigerman merged 4 commits intomainfrom Aug 8, 2025
Merged
Feat!: Decouple forward-only from change categorization#5110izeigerman merged 4 commits intomainfrom
izeigerman merged 4 commits intomainfrom
Conversation
tobymao
reviewed
Aug 7, 2025
eakmanrq
reviewed
Aug 7, 2025
izeigerman
force-pushed
the
feat-decouple-forward-only-from-change-category
branch
from
645b0b2 to
99806a2
Compare
tobymao
approved these changes
Aug 8, 2025
eakmanrq
approved these changes
Aug 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR decouples the
forward-onlybehavior of a snapshot from its change category. Thus, we end up with two independent dimensions:Doing this allows us to apply forward-only changes without losing the benefits of impact analysis and change categorization, particularly for non-breaking changes. So even if either the model or the plan is forward-only, SQLMesh will still categorize changes as
BREAKINGandNON_BREAKINGand will select what needs to be previewed in dev accordingly. For example, previews forINDIRECT_NON_BREAKINGchanges can be safely skipped.This approach is also conceptually more logical, as “forward-only” refers to how a change is applied in production, rather than to the nature of the change itself, unlike other categories.
Additionally, users are never exposed to the
FORWARD_ONLYcategory in the plan output which was quite confusing. Forward-only now only affects whether changes built in dev can be reused in production, as well as whether a full rebuild of a model is required when deploying to production.