Feat: Re-introduce merge for updating auto restatements#5112
Merged
Conversation
vchan
force-pushed
the
vchan/auto-restatement-merge-2
branch
from
375b126 to
d264a76
Compare
erindru
reviewed
Aug 8, 2025
| merge_filter=merge_filter, | ||
| ) | ||
|
|
||
| def get_server_version(self) -> t.Tuple[int, int]: |
Collaborator
There was a problem hiding this comment.
this seems fairly hacky vs just running something like select current_setting('server_version_num') when the EngineAdapter is constructed and storing the result (or even just making this method run the query and use @cached_property to cache the result)
vchan
force-pushed
the
vchan/auto-restatement-merge-2
branch
from
6ea03ee to
36a56f0
Compare
vchan
force-pushed
the
vchan/auto-restatement-merge-2
branch
from
36a56f0 to
75633b2
Compare
izeigerman
approved these changes
Aug 13, 2025
erindru
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5016 was reverted with #5108 because we didn't properly handle fetching server version with pg8000. This PR re-introduces merge for updating auto restatements but with added support for pg8000.