Skip to content

feat(vscode): adding validation to config #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Aug 13, 2025
Merged

feat(vscode): adding validation to config #5126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions vscode/extension/src/utilities/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import { traceVerbose, traceInfo } from './common/log'
import { parse } from 'shell-quote'
import { z } from 'zod'

export interface SqlmeshConfiguration {
projectPath: string
lspEntryPoint: string
}
const configSchema = z.object({
projectPath: z.string(),
lspEntryPoint: z.string(),
})

export type SqlmeshConfiguration = z.infer<typeof configSchema>

/**
* Get the SQLMesh configuration from VS Code settings.
Expand All @@ -20,10 +22,17 @@ function getSqlmeshConfiguration(): SqlmeshConfiguration {
const config = workspace.getConfiguration('sqlmesh')
const projectPath = config.get<string>('projectPath', '')
const lspEntryPoint = config.get<string>('lspEntrypoint', '')
return {

const parsed = configSchema.safeParse({
projectPath,
lspEntryPoint,
})
if (!parsed.success) {
throw new Error(
`Invalid sqlmesh configuration: ${JSON.stringify(parsed.error)}`,
)
}
return parsed.data
}

const stringsArray = z.array(z.string())
Expand Down