Feat(dbt_cli): Use sqlmesh.yaml for config instead of trying to inject dbt_project.yml#5132
Feat(dbt_cli): Use sqlmesh.yaml for config instead of trying to inject dbt_project.yml#5132
Conversation
…t dbt_project.yml
| _inject_default_start_date(project_dir) | ||
| cli_config = get_or_create_sqlmesh_config(project_dir) | ||
| # todo: we will need to build this out when we start storing more than model_defaults | ||
| model_defaults = ( |
There was a problem hiding this comment.
I don't like this alternative config here. It should be normal SQLMesh config.
Please note that despite having a separate CLI command I still want other sqlmesh commands to work as expected. The current direction doesn't ensure that
There was a problem hiding this comment.
The problem with normal SQLMesh config is that it has fields and validations designed for normal SQLMesh projects, which includes a bunch of redundancy that is already specified in dbt_project.yml or profiles.yml in a dbt project (like the entire connection config).
It's also called config.yaml which is kind of generic next to dbt_project.yml instead of something more obvious like sqlmesh.yaml.
But i'll investigate how it can be re-used instead of defining a working subset tuned down to just what's required for the dbt-compatible CLI.
I still want other sqlmesh commands to work as expected
Understood, that helps a lot
|
Closing in favour of #5156 |
2 participants
No description provided.